Skip to content

Commit

Permalink
envconfig: default GRPC_ENFORCE_ALPN_ENABLED to false
Browse files Browse the repository at this point in the history
CRDB at v1.68.0 fails to communicate with CRDB at v1.56.3 due to this
check. This is strange, since CRDB uses gRPC throughout, and in both
v1.56.3 and v1.68.0 uses `tls.NewConfig` which ensures that `NextProtos`
always contains `h2`.

gRPC introduced this check in grpc#7535.

See: cockroachdb/cockroach#136278 (comment)
  • Loading branch information
tbg committed Nov 28, 2024
1 parent 766c020 commit 3093b97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/envconfig/envconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ var (
// option is present for backward compatibility. This option may be overridden
// by setting the environment variable "GRPC_ENFORCE_ALPN_ENABLED" to "true"
// or "false".
EnforceALPNEnabled = boolFromEnv("GRPC_ENFORCE_ALPN_ENABLED", true)
EnforceALPNEnabled = boolFromEnv("GRPC_ENFORCE_ALPN_ENABLED", false)
// XDSFallbackSupport is the env variable that controls whether support for
// xDS fallback is turned on. If this is unset or is false, only the first
// xDS server in the list of server configs will be used.
Expand Down

0 comments on commit 3093b97

Please sign in to comment.