Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestManualCompaction Flaky Test #2613

Closed
raggar opened this issue Jun 8, 2023 · 2 comments · Fixed by #2677
Closed

TestManualCompaction Flaky Test #2613

raggar opened this issue Jun 8, 2023 · 2 comments · Fixed by #2677
Assignees
@raggar
Labels
A-storage T-storage

Comments

@raggar
Copy link
Contributor

raggar commented Jun 8, 2023

Flaky test see https://github.com/cockroachdb/pebble/actions/runs/5212270708/jobs/9405653389

--- FAIL: TestManualCompaction (3.10s)
    compaction_test.go:1261: seed: 1686233880980283084
    --- FAIL: TestManualCompaction/testdata/manual_compaction_set_with_del (0.06s)
        datadriven.go:143: 
            testdata/manual_compaction_set_with_del:84:
             000005
            output didn't match expected:
            @@ -1,6 +1,6 @@
             num-entries: 1
             num-deletions: 1
             num-range-key-sets: 0
             point-deletions-bytes-estimate: 0
            -range-deletions-bytes-estimate: 12[78](https://github.com/cockroachdb/pebble/actions/runs/5212270708/jobs/9405653389#step:4:79)
            +range-deletions-bytes-estimate: 1552
@RaduBerinde
Copy link
Member

Looks like it was introduced in #2585, I can repro on that commit but not the one before.

@itsbilal itsbilal mentioned this issue Jun 12, 2023
Merged
@itsbilal
Copy link
Member

One worthwhile short-term change is to just skip the test while we do the actual fix.

raggar added a commit to raggar/pebble that referenced this issue Jun 12, 2023
@raggar
Skip TestManualCompaction test until fix is found (flaky)
f0ee1dc 
Fixes: cockroachdb#2613
Release note: None
@raggar raggar mentioned this issue Jun 12, 2023
Merged
raggar added a commit to raggar/pebble that referenced this issue Jun 12, 2023
@raggar
Skip TestManualCompaction test until fix is found (flaky)
11bb718 
Informs: cockroachdb#2613
Release note: None
raggar added a commit that referenced this issue Jun 12, 2023
@raggar
Skip TestManualCompaction test until fix is found (flaky)
c1c911a 
Informs: #2613
Release note: None
raggar added a commit to raggar/pebble that referenced this issue Jun 26, 2023
@raggar
pebble: Fix TestManualCompaction Flaky Test
a1a83c9 
This change ensures that `TestManualCompaction` uses table format
`TableFormatPebblev1` as the size was changed in the following pr
cockroachdb#2585

Fixes: cockroachdb#2613
raggar added a commit to raggar/pebble that referenced this issue Jun 26, 2023
@raggar
pebble: Fix TestManualCompaction Flaky Test
81511a5 
This change ensures that `TestManualCompaction` uses table format
`TableFormatPebblev1` as the size was changed in the following pr
cockroachdb#2585

Fixes: cockroachdb#2613
@raggar raggar mentioned this issue Jun 26, 2023
Merged
raggar added a commit that referenced this issue Jun 26, 2023
@raggar
pebble: Fix TestManualCompaction Flaky Test
f4e9d3c 
This change ensures that `TestManualCompaction` uses table format
`TableFormatPebblev1` as the size was changed in the following pr
#2585

Fixes: #2613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raggar raggar

Labels
A-storage T-storage
Projects
Storage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pebble: Fix TestManualCompaction Flaky Test raggar/pebble
3 participants
@itsbilal @RaduBerinde @raggar