Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/cockroachdb/pebble/internal/metamorphic: TestMeta failed #3087

Closed
cockroach-teamcity opened this issue Nov 18, 2023 · 0 comments · Fixed by #3088
Closed

github.com/cockroachdb/pebble/internal/metamorphic: TestMeta failed #3087

cockroach-teamcity opened this issue Nov 18, 2023 · 0 comments · Fixed by #3088

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 18, 2023

github.com/cockroachdb/pebble/internal/metamorphic.TestMeta failed with artifacts on refs/heads/master @ 717d49c2061f:


		===== SEED =====
		1700291915187389844
		===== DIFF =====
		/artifacts/meta/231118-071835.1873667797203/{standard-000,random-004}
		@@ -2558,13 +2558,13 @@
 db1.Get("secu") // [""] pebble: not found #2557
 db1.DeleteRange("irobq@5", "jbjghs@2") // <nil> #2558
 iter21 = db1.NewIter("", "", 0 /* key types */, 0, 0, false /* use L6 filters */, "" /* masking suffix */) // <nil> #2559
 iter21.SeekPrefixGE("cjcwog@5") // [false] <nil> #2560
 db1.SingleDelete("outmydba@8", true /* maybeReplaceDelete */) // <nil> #2561
-iter21.Last() // [true,"zshisublycg@2","vpwplonetyi",<no range>] <nil> #2562
-iter21.Prev("efhaskflofi@2") // [valid,"ydrxi@7","lgovenptjoprftdxcbp",<no range>] <nil> #2563
-iter21.NextPrefix() // [true,"zshisublycg@2","vpwplonetyi",<no range>] <nil> #2564
+iter21.Last() // [true,"zshisublycg@1","dpajzlikwmqjzvv",<no range>] <nil> #2562
+iter21.Prev("efhaskflofi@2") // [valid,"zshisublycg@2","vpwplonetyi",<no range>] <nil> #2563
Help

To reproduce, try:

go test -tags 'invariants' -exec 'stress -p 1' -timeout 0 -test.v -run TestMeta$ ./internal/metamorphic -seed 1700291915187389844 -ops "uniform:5000-10000"

This test on roachdash | Improve this report!

yatwql pushed a commit to yatwql/pebble that referenced this issue Nov 19, 2023
In bfb2e6a (cockroachdb#3081) a small refactor the handling of DELSIZED introduced a bug
when a DELSIZED shadows a SINGLEDEL. When a DELSIZED and a SINGLEDEL meet in a
compaction, we began accidentally emitting a SINGLEDEL rather than a DEL,
weakening the tombstone. Previously the problematic code branch was only ever
executed when a DELSIZED and DEL met, so iterKey.Kind() was always DEL.

Fix cockroachdb#3087.
RaduBerinde pushed a commit to RaduBerinde/pebble that referenced this issue Nov 30, 2023
In bfb2e6a (cockroachdb#3081) a small refactor the handling of DELSIZED introduced a bug
when a DELSIZED shadows a SINGLEDEL. When a DELSIZED and a SINGLEDEL meet in a
compaction, we began accidentally emitting a SINGLEDEL rather than a DEL,
weakening the tombstone. Previously the problematic code branch was only ever
executed when a DELSIZED and DEL met, so iterKey.Kind() was always DEL.

Fix cockroachdb#3087.
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant