db: use objstorage to find obsolete objects #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bananabrick
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Code looks
Could we test this, at least manually.
- Create some fake sst files using the sst file naming format in the Pebble directory.
- Reopen pebble. Pebble won't try to read the fake sst files and in the
scanObsoleteFilesstep, they should be added to the obsolete file list. - Make sure that the fake sst files were deleted by Pebble.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
RaduBerinde
force-pushed
the
list-objects
branch
from
812a967
to
c583af2
Compare
RaduBerinde
commented
Feb 17, 2023
There was a problem hiding this comment.
Good idea, I extended the cleaner test.
Reviewable status: 0 of 5 files reviewed, all discussions resolved
Ignore SST files in the listing and instead get the list of objects from the objstorage provider. Extend the cleaner test to check for removal of extra sst files.
RaduBerinde
force-pushed
the
list-objects
branch
from
c583af2
to
1a69ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore SST files in the listing and instead get the list of objects from the objstorage provider.