base: allow CompareSuffixes to be stricter than Compare #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows `CompareSuffixes` to be stricter than `Compare` (when the prefixes are equal). This will allow reverting the CRDB comparer behavior to be consistent with previous releases (avoiding $replica inconsistency). Informs cockroachdb/cockroach#130533
|
This change is |
jbowens
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
CompareSuffixesto be stricter thanCompare(when the prefixes are equal). This will allow reverting the CRDB
comparer behavior to be consistent with previous releases (avoiding
$replica inconsistency).
Informs cockroachdb/cockroach#130533