sstable,colblk: minor bug fixes #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aadityasondhi and @jbowens)
sstable/colblk/data_block.go line 53 at r1 (raw file):
// // If no key has been written yet, ComparePrev returns a KeyComparison with // only PrefixLen set.
[nit] Feels like UserKeyComparison should be 1 not 0 in this case
Define the behavior of KeyWriter.ComparePrev when called on a KeyWriter that has no previously-written key.
Populate the IndexPartitions table-level property in the the columnar sstable writer.
Previously, the test4bSuffixComparer test comparer wasn't setting CompareSuffixes. Update the comparer to simply copy the default comparer override Split and Name.
jbowens
commented
Sep 25, 2024
There was a problem hiding this comment.
TFTR!
CI hit a metamorphic test failure that reproduces on master. Filed #3963
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @aadityasondhi and @RaduBerinde)
sstable/colblk/data_block.go line 53 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] Feels like
UserKeyComparisonshould be 1 not 0 in this case
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colblk: define behavior of KeyWriter.ComparePrev with no previous
Define the behavior of KeyWriter.ComparePrev when called on a KeyWriter that
has no previously-written key.
sstable: set IndexPartitions property in columnar sstable writer
Populate the IndexPartitions table-level property in the the columnar sstable
writer.