Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colblk: add SeekUnsetBitGE/LE #3971

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

RaduBerinde
Copy link
Member

colblk: move out nextInBit/prevInBit functions

This change uninlines these functions and adds a test for them.

colblk: rename Successor/Predecessor to SeekSetBitGE/SeekSetBitLE

The previous names were misleading since we can return the same
index.

colblk: add SeekUnsetBitGE/LE

These variants will be useful for skipping blocks of set bits, for
example to skip obsolete keys.

This change uninlines these functions and adds a test for them.
The previous names were misleading since we can return the same
index.
These variants will be useful for skipping blocks of set bits, for
example to skip obsolete keys.
@RaduBerinde RaduBerinde requested a review from a team as a code owner September 26, 2024 17:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 6 of 6 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaduBerinde)


sstable/colblk/bitmap_test.go line 90 at r1 (raw file):

	for _, w := range words {
		// Check that we can reconstruct the word if we jump from set bit to set
		// bit.

nice test

@RaduBerinde
Copy link
Member Author

TFTR!

@RaduBerinde RaduBerinde merged commit 50864fa into cockroachdb:master Sep 26, 2024
12 checks passed
@RaduBerinde RaduBerinde deleted the bitmap-stuff branch September 26, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants