Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: fill missing parameters #3983

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

caicancai
Copy link
Contributor

@caicancai caicancai commented Sep 29, 2024

The format log is missing a parameter

@caicancai caicancai requested a review from a team as a code owner September 29, 2024 13:13
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@caicancai
Copy link
Contributor Author

caicancai commented Sep 29, 2024

@RaduBerinde @jbowens If you have time, could you help me take a look? Thanks

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jbowens)

@RaduBerinde RaduBerinde merged commit 79166ef into cockroachdb:master Oct 2, 2024
12 checks passed
@caicancai caicancai deleted the dirname branch October 2, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants