colblk: show iter commands #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
It's pretty hard to look at an `iter` testcase and see which key matches which command. This commit adds a `ShowCommands` option and uses it for the data block tests.
RaduBerinde
force-pushed
the
iter-show-commands
branch
from
97728a2
to
7104187
Compare
jbowens
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
jbowens
added a commit
to jbowens/pebble
that referenced
this pull request
Oct 2, 2024
This change is analagous to cockroachdb#3988 but for the sstable package's datadriven iter command. Including the command in the output makes it more legible.
jbowens
added a commit
that referenced
this pull request
Oct 2, 2024
This change is analagous to #3988 but for the sstable package's datadriven iter command. Including the command in the output makes it more legible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty hard to look at an
itertestcase and see which keymatches which command. This commit adds a
ShowCommandsoption anduses it for the data block tests.