block,colblk: tighten iterator semantics #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit more tightly defines the IndexBlockIterator semantics around behavior after a call to Invalidate and around positioning operations called after exhaustion. These semantics match the rowblk implementation and are currently required by the sstable iterator. In the future, we may consider alternative semantics through updating the sstable iterator.
|
This change is |
jbowens
changed the title
Define the semantics of calling a positioning method on an invalidated DataBlockIterator. The sstable iterator currently depends on these semantics.
jbowens
force-pushed
the
iter-semantics
branch
from
55a6295
to
1ca10a8
Compare
RaduBerinde
approved these changes
Oct 1, 2024
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block,colblk: tighten index iterator semantics
This commit more tightly defines the IndexBlockIterator semantics around behavior after a call to Invalidate and around positioning operations called after exhaustion. These semantics match the rowblk implementation and are currently required by the sstable iterator.
In the future, we may consider alternative semantics through updating the sstable iterator.
block,colblk: tighten data block iterator semantics
Define the semantics of calling a positioning method on an invalidated
DataBlockIterator. The sstable iterator currently depends on these semantics.