ci: use go1.23 #4012
Merged
ci: use go1.23 #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
upgrade-go-123
branch
from
17faff9
to
8005f50
Compare
rickystewart
commented
Oct 7, 2024
| @@ -132,7 +132,7 @@ endif | |||
|
|
|||
| .PHONY: format | |||
| format: | |||
| go install -C internal/devtools github.com/cockroachdb/crlfmt && crlfmt -w -tab 2 ../.. | |||
There was a problem hiding this comment.
I was pretty perplexed by this. To me this ../.. seems transparently obviously wrong and it should be .. This change fixes CI (link). I may be missing something and if so, let me know.
There was a problem hiding this comment.
Indeed, thanks for the fix. I think there was an intermediate version that used go run and the working dir would be ./internal/devtools.
rickystewart
force-pushed
the
upgrade-go-123
branch
from
8005f50
to
64e890c
Compare
Part of: CRDB-41921
rickystewart
force-pushed
the
upgrade-go-123
branch
from
64e890c
to
9bfb2cf
Compare
|
Do we plan to switch to go 1.23 for 24.3? If not, we should either hold off on this, or test both 1.22 and 1.23 in CI (edit: fixed typo in version) |
|
Yes, we plan to switch to Go 1.23 for 24.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: CRDB-41921