This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
upgrade @cockroachlabs-admin-ui-components@^0.1.24 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koorosh
force-pushed
the
upgrade-admin-ui-components-0.1.24
branch
from
59831cc to
a610958
Compare
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Dec 1, 2020
50869: ui: Correct responses for restricted access to non-admin users r=koorosh a=koorosh Resolves #48152, #50360 Depends on cockroachdb/admin-ui-components#37 Depends on cockroachdb/yarn-vendored#44 Previously, request handlers for node locations and eventslogs didn't check if the user has an admin role or not and proceeds with an attempt to query data from tables with granted permissions for admin users only. This error handled as server error then. Current change validates if a user has admin role before requesting data from tables and responds with Permission denied error when user doesn't have an admin role. UI changes: - Add InlineAlert component to display redesigned messages; **Screens** Single info message (Restricted permissions) <img width="1174" alt="Screenshot 2020-07-02 at 18 34 03" src="https://user-images.githubusercontent.com/3106437/86460281-c3d7c880-bd30-11ea-9ef4-006e436c26e8.png"> Single error message <img width="1154" alt="Screenshot 2020-07-02 at 18 41 54" src="https://user-images.githubusercontent.com/3106437/86460294-cd613080-bd30-11ea-9e81-9009f4d47b5e.png"> Multiple error messages <img width="1259" alt="Screenshot 2020-07-02 at 18 24 34" src="https://user-images.githubusercontent.com/3106437/86460323-d9e58900-bd30-11ea-81bf-6ff47fdadba1.png"> Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.