store: add initial S3 store implementation #3
Conversation
| ) | ||
|
|
||
| const ( | ||
| // AccountParam is the AWS access key ID. |
There was a problem hiding this comment.
These comments are pointless.
There was a problem hiding this comment.
some of these are required by the linter.
| Obfuscated = "******" | ||
| ) | ||
|
|
||
| // ErrMissingParam is returned when required parameters are missing. |
There was a problem hiding this comment.
required by linter.
| // candidateConfigs provides a set of candidate configurations for the S3 store. | ||
| func (s *s3Store) candidateConfigs() iter.Seq[Store] { | ||
| return func(yield func(Store) bool) { | ||
| combos := [][]string{ |
There was a problem hiding this comment.
why redefine this here and not put it in the outer function, or even on the top level?
There was a problem hiding this comment.
good point. Adding a comment for now.
internal/store/s3.go
Outdated
| Key: aws.String(probeKey), | ||
| }) | ||
| if err != nil { | ||
| // we were able to write this object, it must exists. |
There was a problem hiding this comment.
But there was still an error? so I'm a little confused by workflow here
There was a problem hiding this comment.
Update the comment. This workflow is just to verify that we can write, read, delete, list an object.
| } | ||
| } | ||
| } | ||
|
|
||
| // Store represents a destination to perform a backup/restore. | ||
| type Store interface { |
There was a problem hiding this comment.
Can you rename store. Since that usually means a hard drive. ExternalStorage or something like that perhaps?
Introduce `internal/store/s3.go` with an S3-backed Store implementation: - Constructed via `S3FromEnv` using AWS-style environment variables. - Supports alternates (path-style, skip checksum, skip TLS) with a safe baseline first. - Probes connectivity by writing, reading, and deleting a `_blobcheck` object.
Introduce
internal/store/s3.gowith an S3-backed Store implementation:S3FromEnvusing AWS-style environment variables._blobcheckobject.