Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using the shell to run commands #138

Closed
wants to merge 2 commits into from
Closed

Stop using the shell to run commands #138

wants to merge 2 commits into from

Conversation

hhhhhhhhhn
Copy link

This prevents RCE with $(...) syntax, and makes the regex escaping functions unnecessary, and the code slightly cleaner.

@hhhhhhhhhn
Stop using the shell to run commands
ad13083 
This prevents RCE with $(...) syntax, and makes the regex escaping
functions unnecessary, and the code slightly cleaner.
@hhhhhhhhhn
Merge https://github.com/cocktailpeanut/dalai
3793215
myyk
myyk approved these changes Mar 29, 2023
View reviewed changes
Copy link

@myyk myyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, but it needs to be updated because of MCs.

@myyk myyk mentioned this pull request Mar 29, 2023
Open
@myyk
Copy link

myyk commented Mar 29, 2023

I fixed it in #320

@hhhhhhhhhn hhhhhhhhhn closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myyk myyk myyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhhhhhhhhn @myyk