Merge pull request #1127 from cocoa-mhlw/fix/500error_when_valid_JWS

fix error handling and fix error message
cocoa-mhlw · Sep 2, 2022 · 6024d50 · 6024d50
2 parents 28a16ef + 05d484f
commit 6024d50
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Covid19Radar.Api/Services/DeviceValidationAndroidService.cs b/src/Covid19Radar.Api/Services/DeviceValidationAndroidService.cs
@@ -112,7 +112,8 @@ private AndroidAttestationStatement ParsePayload(string signedAttestationStateme
  catch (ArgumentException)
  {
  // The token is not in a valid JWS format.
- return null;
+ Logger.LogError("The token is not in a valid JWS format");
+ throw;
  }
 
  // We just want to validate the authenticity of the certificate.
@@ -135,7 +136,7 @@ private AndroidAttestationStatement ParsePayload(string signedAttestationStateme
  catch (ArgumentException)
  {
  // Signature validation failed.
- Logger.LogError("The token is not in a valid JWS format");
+ Logger.LogError("Signature validation failed");
  throw;
  }