Fix/sonarcloud issues

src/Covid19Radar.Api.Common/DataAccess/IDiagnosisRepository.cs

@@ -12,9 +12,9 @@ public interface IDiagnosisRepository
  {
 
  Task<DiagnosisModel[]> GetNotApprovedAsync();
- Task<DiagnosisModel> GetAsync(string SubmissionNumber, string UserUuid);
+ Task<DiagnosisModel> GetAsync(string submissionNumber, string sserUuid);
 
- Task<DiagnosisModel> SubmitDiagnosisAsync(string SubmissionNumber, DateTimeOffset timestamp, string UserUuid, TemporaryExposureKeyModel[] Keys);
+ Task<DiagnosisModel> SubmitDiagnosisAsync(string submissionNumber, DateTimeOffset timestamp, string userUuid, TemporaryExposureKeyModel[] Keys);
 
  Task DeleteAsync(IUser user);
  }

src/Covid19Radar.Api.Common/Services/ValidationServerService.cs

@@ -31,6 +31,7 @@ public ValidationServerService(IConfiguration config, ILogger<ValidationServerSe
 
  public IValidationServerService.ValidateResult Validate(HttpRequest req)
  {
+ Logger.LogInformation($"{nameof(ValidationServerService)}#{nameof(Validate)}");
  if (AzureFrontDoorRestrictionEnabled)
  {
  if (!req.Headers.ContainsKey("X-Azure-FDID"))

src/Covid19Radar.Api/DiagnosisApi.cs

@@ -22,7 +22,6 @@ namespace Covid19Radar.Api
 {
  public class DiagnosisApi
  {
- private readonly IDiagnosisRepository DiagnosisRepository;
  private readonly ITemporaryExposureKeyRepository TekRepository;
  private readonly IDeviceValidationService DeviceCheck;
  private readonly IVerificationService VerificationService;
@@ -39,7 +38,6 @@ public DiagnosisApi(
  IValidationServerService validationServerService,
  ILogger<DiagnosisApi> logger)
  {
- DiagnosisRepository = diagnosisRepository;
  TekRepository = tekRepository;
  DeviceCheck = deviceCheck;
  Logger = logger;

src/Covid19Radar.Api/Services/CustomVerificationService.cs

@@ -3,8 +3,6 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
 using Covid19Radar.Api.DataAccess;
-using Covid19Radar.Api.DataStore;
-using Microsoft.Azure.Cosmos;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
 using Newtonsoft.Json;
@@ -18,7 +16,6 @@ namespace Covid19Radar.Api.Services
 {
  public class CustomVerificationService : IVerificationService
  {
- private readonly IConfiguration Config;
  private readonly ICustomVerificationStatusRepository CustomVerification;
  private readonly ILogger<CustomVerificationService> Logger;
  private readonly X509Certificate2 Cert;
@@ -29,10 +26,9 @@ public class CustomVerificationService : IVerificationService
  private readonly string VerificationPayloadParameterName;
 
  public CustomVerificationService(IConfiguration config,
- ICustomVerificationStatusRepository customVerification, 
+ ICustomVerificationStatusRepository customVerification,
  ILogger<CustomVerificationService> logger)
  {
- Config = config;
  CustomVerification = customVerification;
  Logger = logger;
  var cert = config.VerificationPayloadPfx();
@@ -50,18 +46,19 @@ public CustomVerificationService(IConfiguration config,
  VerificationPayloadParameterName = config.VerificationPayloadParameterName();
  // option api secret for api management
  ApiSecret = config.VerificationPayloadApiSecret();
- if (!string.IsNullOrWhiteSpace(ApiSecret)) {
+ if (!string.IsNullOrWhiteSpace(ApiSecret))
+ {
  Client.DefaultRequestHeaders.Add("Ocp-Apim-Subscription-Key", ApiSecret);
  }
  }
 
- public async Task<int> VerificationAsync(string verificationPayload)
+ public async Task<int> VerificationAsync(string payload)
  {
  Logger.LogInformation($"start {nameof(VerificationAsync)}");
- var payload = $@"{{
-""{VerificationPayloadParameterName}"": ""{verificationPayload}""
-}}";
- var content = new StringContent(payload);
+
+ var content = new StringContent($@"{{
+""{VerificationPayloadParameterName}"": ""{payload}""
+}}");
  var response = await Client.PostAsync(Url, content);
  if (!response.IsSuccessStatusCode) return 503;
 

src/Covid19Radar.Api/TemporaryExposureKeysApi.cs

@@ -20,7 +20,6 @@ namespace Covid19Radar.Api
  public class TemporaryExposureKeysApi
  {
  private readonly ITemporaryExposureKeyExportRepository TekExport;
- private readonly ILogger<TemporaryExposureKeysApi> Logger;
  private readonly string ExportKeyUrl;
  private readonly string TekExportBlobStorageContainerPrefix;
  private readonly IValidationServerService ValidationServerService;
@@ -32,7 +31,6 @@ public TemporaryExposureKeysApi(
  ILogger<TemporaryExposureKeysApi> logger
  )
  {
- Logger = logger;
  TekExport = tekExportRepository;
  ExportKeyUrl = config.ExportKeyUrl();
  TekExportBlobStorageContainerPrefix = config.TekExportBlobStorageContainerPrefix();

src/Covid19Radar.Api/V2DiagnosisApi.cs

@@ -23,8 +23,6 @@ namespace Covid19Radar.Api
  public class V2DiagnosisApi
  {
  private const string CHAFF_HEADER = "X-Chaff";
-
- private readonly IDiagnosisRepository DiagnosisRepository;
  private readonly ITemporaryExposureKeyRepository TekRepository;
  private readonly IDeviceValidationService DeviceCheck;
  private readonly IVerificationService VerificationService;
@@ -41,7 +39,6 @@ public V2DiagnosisApi(
  IValidationServerService validationServerService,
  ILogger<V2DiagnosisApi> logger)
  {
- DiagnosisRepository = diagnosisRepository;
  TekRepository = tekRepository;
  DeviceCheck = deviceCheck;
  Logger = logger;