This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

イベントログの設定画面のアクセシビリティを修正 #1068

Merged

1 commit merged into develop from feature/event-log-a11y

Jul 8, 2022

ghost commented Jul 7, 2022 •

edited by ghost

Loading

Issue 番号 / Issue ID

Close #

目的 / Purpose

イベントログの設定画面のアクセシビリティを修正

変更内容 / Changes

チェックボックスの読み上げを独自に行うようにした
- 標準だとiOSはオン・オフを読み上げない
- Androidは、CheckBoxにAutomationProperty.Nameを指定するとテキストも表示されてしまう
  - CheckBoxはTextプロパティは用意されておらず見た目も変えられない

破壊的変更をもたらしますか / Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request の種類 / Pull Request type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: A11y

確認事項 / What to check

[ ]

その他 / Other information

Internal IDs:

Product Backlog Item 7404


Fixed a11y

9393bc3

ghost commented

View reviewed changes

Covid19Radar/Covid19Radar/Views/Settings/EventLogSettingPage.xaml

  x:Class="Covid19Radar.Views.EventLogSettingPage"
  ios:Page.UseSafeArea="true"
  Style="{StaticResource DefaultPageStyle}"
  Title="{x:Static resources:AppResources.EventLogSettingPageTitle}">
  <ContentView>
  <StackLayout>
  <Label
- AutomationProperties.IsInAccessibleTree="True"

Author

ghost Jul 7, 2022

画面最初の要素でこれを指定(TrueでもFalseでも)すると、画面遷移時のTalkBackの挙動がおかしくなる。

ghost requested review from a user, cocoa-dev003 and cocoa-dev009

July 7, 2022 05:41

ghost self-assigned this

sonarcloud bot commented Jul 7, 2022

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

8.3% Coverage
0.0% Duplication

cocoa-dev003 approved these changes

View reviewed changes

ghost approved these changes

View reviewed changes

ghost merged commit ae6e055 into develop

ghost deleted the feature/event-log-a11y branch

July 8, 2022 02:24

This pull request was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.