Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

イベントログの書き出しの不具合を修正 #1074

Merged
1 commit merged into from
Jul 11, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 8, 2022

Issue 番号 / Issue ID

  • Close #

目的 / Purpose

  • イベントログの書き出しの不具合を修正

変更内容 / Changes

  • ファイル名生成時ににBase64を使用していたが、ファイル名として適切でないスラッシュを含む状態だった
    • URL Safe なBase64エンコードを行うように修正

破壊的変更をもたらしますか / Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request の種類 / Pull Request type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

確認事項 / What to check

  • [ ]

その他 / Other information


Internal IDs:

  • Bug 7908

@ghost ghost requested review from a user, cocoa-dev003 and cocoa-dev009 July 8, 2022 06:58
@ghost ghost self-assigned this Jul 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ghost ghost merged commit 6f86521 into develop Jul 11, 2022
@ghost ghost deleted the feature/event-log-file-name branch July 11, 2022 00:46
@keiji
Copy link
Collaborator

keiji commented Jul 11, 2022

@cocoa-dev004
これぜんぜん気づいてませんでした。ありがとうございます!
(そしてC#でBase64UrlEncodeするの、ちょっと面倒ですね…)

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants