Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

接触結果を確認で画面が開かないことがある件の対応 #1100

Merged
3 commits merged into from
Aug 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2022

Issue 番号 / Issue ID

目的 / Purpose

  • 接触結果を確認で画面が開かないことがある件の対応

変更内容 / Changes

  • GetExposureRiskCalculationConfigurationAsync()の際に通信状態が悪くタイムアウトした際にエラーが表示され画面遷移ができない件の修正
    • 取得時にタイムアウトもcatchするように修正
    • catchした際はキャッシュ、キャッシュがない場合はアプリで定義されたデフォルト値が返され使用される
  • 接触結果のサブ画面では都度再取得させず、取得済みのものを使用するように修正

破壊的変更をもたらしますか / Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request の種類 / Pull Request type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

確認事項 / What to check

  • [ ]

その他 / Other information

  • タイムアウトは10秒

Internal IDs:

  • Bug 7646

@ghost ghost requested review from a user, cocoa-dev003 and cocoa-dev009 August 1, 2022 06:30
@ghost ghost self-assigned this Aug 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.4% 57.4% Coverage
0.0% 0.0% Duplication

@ghost ghost merged commit aedf237 into develop Aug 3, 2022
@ghost ghost deleted the feature/exposure-risk-calc-configuraition-timeout branch August 3, 2022 01:36
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants