Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

利用調査画面のデザインと送信内容の修正 #1173

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

cocoa-dev003
Copy link
Contributor

@cocoa-dev003 cocoa-dev003 commented Oct 17, 2022

Issue 番号 / Issue ID

  • Close #

目的 / Purpose

  • 利用調査画面のデザイン修正
  • デザインに合わせて送信する内容も修正

変更内容 / Changes

  • 利用調査画面のデザイン修正
    • 回答の選択肢は修正していません
  • デザインに合わせて送信する内容も修正
    • json の値が null の時フィールドを含めるかどうかは検討中

破壊的変更をもたらしますか / Does this introduce a breaking change?

[] Yes
[x] No

Pull Request の種類 / Pull Request type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

確認事項 / What to check

  • [ ]

その他 / Other information


Internal IDs:

  • PBI 8856

@cocoa-dev003 cocoa-dev003 self-assigned this Oct 17, 2022
@cocoa-dev003 cocoa-dev003 requested review from a user and cocoa-dev009 October 17, 2022 02:23
@cocoa-dev003 cocoa-dev003 changed the title アンケート回答画面のデザインと送信内容の修正 利用調査画面のデザインと送信内容の修正 Oct 17, 2022
@@ -64,40 +66,40 @@ public async Task BuildSurveyContentTests_HasExposureDataProvision()
}
}
});
_mockUserDataRepository.Setup(x => x.GetStartDate()).Returns(new DateTime(2022, 1, 1, 0, 0, 0, DateTimeKind.Local));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetStartDateはUTCで返されるはずです

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、修正しました。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下の意図として、UTCの2022/01/01 00:00で良いですか?
日本時間の2022/01/01 00:00とするなら、-9時間したほうがいいと思います。

_mockUserDataRepository.Setup(x => x.GetStartDate()).Returns(new DateTime(2022, 1, 1, 0, 0, 0, DateTimeKind.Utc));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい、日本時間は特に考えずUTCの2022/01/01 00:00を設定しています。

@cocoa-mhlw cocoa-mhlw deleted a comment from 01235110219565 Oct 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@cocoa-dev003 cocoa-dev003 merged commit adfc824 into develop Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants