This repository has been archived by the owner on Apr 12, 2023. It is now read-only.
Add navigation test for TutorialPage3ViewModel #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiji
reviewed
Jul 25, 2021
| @@ -0,0 +1,108 @@ | |||
| /* This Source Code Form is subject to the terms of the Mozilla Public | |||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ | |||
Covid19Radar/Tests/Covid19Radar.UnitTests/Covid19Radar.UnitTests.csproj
Outdated
Show resolved
Hide resolved
Comment on lines
44
to
48
| mockUserDataService.Reset(); | ||
| mockUserDialogs.Reset(); | ||
| mockNavigationService.Reset(); | ||
| mockLoggerService.Reset(); | ||
| mockTermsUpdateService.Reset(); |
There was a problem hiding this comment.
nitpickですが、ここの並びはクラスのメンバ変数の宣言の並びと合わせておくと、将来的に記述漏れに気づきやすそうです。
Comment on lines
71
to
74
| .Returns(Task.Run(() => | ||
| { | ||
| return true; | ||
| })); |
There was a problem hiding this comment.
一行で書いてしまった方がシンプルかもしれません（意図がつかみにくくなる・他と記述を合わせたなどの理由がある場合はこのままで）
Suggested change
| .Returns(Task.Run(() => | |
| { | |
| return true; | |
| })); | |
| .Returns(Task.Run(() => true)); |
Comment on lines
93
to
96
| .Returns(Task.Run(() => | ||
| { | ||
| return false; | ||
| })); |
There was a problem hiding this comment.
ここも同様につぎのようにも書けます。
Suggested change
| .Returns(Task.Run(() => | |
| { | |
| return false; | |
| })); | |
| .Returns(Task.Run(() => false)); |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| using System; |
| using Covid19Radar.ViewModels; | ||
| using Moq; | ||
| using Prism.Navigation; | ||
| using Xamarin.Essentials; |
|
何回かに一回テストがコケることが発覚したので一旦draftに戻しますmm (原因不明...) |
ghost
reviewed
Apr 18, 2022
| } | ||
|
|
||
| [Fact] | ||
| public void Dispose() |
There was a problem hiding this comment.
UserDialogs.Instanceのnullクリアが必要です。
逆にほかは毎回初期化されるものなので、ある分には問題ありませんが無くても良いです。
| mockTermsUpdateService = mockRepository.Create<ITermsUpdateService>(); | ||
| } | ||
|
|
||
| [Fact] |
|
|
||
| namespace Covid19Radar.UnitTests.ViewModels | ||
| { | ||
| public class TutorialPage3ViewModelTests |
There was a problem hiding this comment.
IDisposableを継承する必要があります。（Dispose()が呼ばれません）
|
|
||
| mockUserDataService | ||
| .Setup(product => product.RegisterUserAsync()) | ||
| .Returns(Task.Run(() => { return true; })); |
There was a problem hiding this comment.
非同期メソッドの戻り値の設定にはReturnsAsync()が使えるかと思います。
| mockUserDialogs.Verify(x => x.HideLoading(), Times.Once()); | ||
| mockUserDialogs.Verify(x => x.AlertAsync(It.IsAny<string>(), It.IsAny<string>(), "OK", null), Times.Never()); | ||
|
|
||
| mockNavigationService.Verify(x => x.NavigateAsync("PrivacyPolicyPage"), Times.Once); |
There was a problem hiding this comment.
Times.OnceはメソッドですのでTimes.Once()でお願いします。
※他も同様の箇所の対応をお願いします
|
まずはじめにこちらcocoa-mhlwのブランチにマージして作業を続けます。 |
keiji
changed the base branch from
develop
to
feature/kazuhiro4949_tutorialpage3viewmodel_naivation_test
keiji
merged commit 89b9604
into
cocoa-mhlw:feature/kazuhiro4949_tutorialpage3viewmodel_naivation_test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 番号 / Issue ID
目的 / Purpose
ライセンス同意画面ではライセンスの同意後に通信を行い、成功時と失敗時に表示を出し分けています。
ここの分岐部分の仕様に関してユニットテストを追加しました。
破壊的変更をもたらしますか / Does this introduce a breaking change?
Pull Request の種類 / Pull Request type
検証方法 / How to test
以下で今回作成したテストが通るのを確認しています
コードの入手 / Get the code
コードの検証 / Test the code
確認事項 / What to check
その他 / Other information