This repository has been archived by the owner on Apr 12, 2023. It is now read-only.
Improve migration tests. #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiji
commented
Oct 8, 2021
Comment on lines
+38
to
+39
| private static DateTime CreateDateTime(DateTime dateTime) | ||
| => DateTime.ParseExact(dateTime.ToString(FORMAT_DATETIME), FORMAT_DATETIME, null); |
There was a problem hiding this comment.
一度、現在のフォーマットに基づいて文字列に変換した上でDateTimeとしてパースする（＝タイムゾーンを削除する）
| var startDateTime = DateTime.UtcNow; | ||
| var termsOfServiceLastUpdateDateJst = DateTime.SpecifyKind(CreateTermsUpdateDateTime(JstNow.AddMinutes(1)), DateTimeKind.Unspecified); | ||
| var privacyPolicyLastUpdateDateJst = DateTime.SpecifyKind(CreateTermsUpdateDateTime(JstNow.AddMinutes(2)), DateTimeKind.Unspecified); | ||
| var startDateTime = CreateDateTime(DateTime.UtcNow); |
There was a problem hiding this comment.
startDateTimeについてもタイムゾーンを取り除く
| @@ -731,7 +731,8 @@ await CreateService() | |||
|
|
|||
| // StartDateTime | |||
| var startDateTimePref = _dummyPreferencesService.GetValue(PreferenceKey.StartDateTimeEpoch, 0L); | |||
| Assert.Equal(startDateTime.ToUnixEpoch(), startDateTimePref); | |||
| var startDateTimeUtc = DateTime.SpecifyKind(startDateTime, DateTimeKind.Utc); | |||
There was a problem hiding this comment.
この時点ではstartDateTimeからはタイムゾーン情報がないので正しくUnixEpochに変換できないため、DateTimeKind.Utcを付け直す。
この処理はテストの想定される値を正しく計算するためのもの、マイグレーション処理そのものには作用しない。
kazuhiro4949
approved these changes
Nov 3, 2021
|
手元でのテストの実行結果も問題なさそうです |
ghost
merged commit 
|
@keiji |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 番号 / Issue ID
目的 / Purpose
破壊的変更をもたらしますか / Does this introduce a breaking change?
Pull Request の種類 / Pull Request type
検証方法 / How to test
コードの入手 / Get the code
コードの検証 / Test the code
確認事項 / What to check
その他 / Other information