This repository has been archived by the owner on Apr 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
基準値未満の接触画面リファインメント #889
Merged
kazuhiro4949
merged 3 commits into
cocoa-mhlw:feature/beta
from
keiji:beta/improve_low_risk_exposure
Feb 23, 2022
Merged
基準値未満の接触画面リファインメント #889
kazuhiro4949
merged 3 commits into
cocoa-mhlw:feature/beta
from
keiji:beta/improve_low_risk_exposure
Feb 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
</data> | ||
<data name="LowRiskContactPageAnnotationDecription2" xml:space="preserve"> | ||
<value>日時については、協定世界時(UTC)を設定されているタイムゾーンに変換して、期間として表示しています。</value> | ||
<comment>TODO:日時については、協定世界時(UTC)をを設定されているタイムゾーンに変換して、期間として表示しています。</comment> | ||
</data> | ||
<data name="LowRiskContactPageAnnotationDecription2" xml:space="preserve"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
重複している?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
内容は同じですが画面が別なので2箇所に書いてあります。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nameをキーに値を引いてきていると理解していたのですが、例えばこっちのLowRiskContactPageAnnotationDecription2が持つvalueを変更した場合にはExposureCheckPageには特に影響がないことは保証されているものなんでしょうか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
おっと、同じキーが2つあるのは良くないですね。
直します!(ビルド通るんか……
keiji
commented
Feb 23, 2022
kazuhiro4949
approved these changes
Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 番号 / Issue ID
目的 / Purpose
破壊的変更をもたらしますか / Does this introduce a breaking change?
Pull Request の種類 / Pull Request type
検証方法 / How to test
コードの入手 / Get the code
コードの検証 / Test the code
確認事項 / What to check
その他 / Other information