Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Not visible to VoiceOver #152

Open
michaeljtsai opened this issue Jan 19, 2021 · 4 comments
Open

Not visible to VoiceOver #152

michaeljtsai opened this issue Jan 19, 2021 · 4 comments

Comments

@michaeljtsai
Copy link
Contributor

I think this used to work, but as of now (compiling with Xcode 12.3, running on macOS 10.15.7 and 11.2 beta), it’s not possible to select the MASShortcutView using VoiceOver, and I don’t hear the accessibility notifications when the shortcut is changed. I think I was able to fix this by overriding -[MASShortcutView isAccessibilityElement] to return YES. The documentation suggests that this is necessary, so I don’t understand why it was working for me before without doing this.

@shpakovski
Copy link
Collaborator

@michaeljtsai Thanks a lot for the heads up! Could you please make a pull request? 🙏

michaeljtsai added a commit to michaeljtsai/MASShortcut that referenced this issue Jan 20, 2021
This makes it possible to select it using VoiceOver and prevents the system from ignoring the accessibility notification that's posted when the shortcut is changed.
@michaeljtsai
Copy link
Contributor Author

michaeljtsai commented Jan 20, 2021

I was hoping someone who knows more about this would have insight into why it worked before without this and therefore whether this is in fact the right fix. But, yes, I can make a PR: #153

@Kentzo
Copy link

Kentzo commented Jan 20, 2021

@michaeljtsai Probably Apple used to have additional checks that were not documented (e.g. by explicitly looking for other accessibility methods in the interface).

By the way, could you try your accessibility testing routine with https://github.com/Kentzo/ShortcutRecorder? It appears to work for me but I do not casually use Accessibility.

shpakovski pushed a commit that referenced this issue Jan 21, 2021
This makes it possible to select it using VoiceOver and prevents the system from ignoring the accessibility notification that's posted when the shortcut is changed.
@michaeljtsai
Copy link
Contributor Author

That works, too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants