This repository has been archived by the owner on Mar 21, 2020. It is now read-only.
Emit payment-error event #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t will allow test to pass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply ties into the onError event from
paypal-checkout. Same general flow aspayment-cancelledevent implementation. I also reverted the zoid/xcomponent unit test (so all tests pass again) and left the rebuild out of this branch. I assume you will want to do that in your normal pre-release setup.At minimum allows to catch if there were any errors in request. I have been able to catch a
DUPLICATE_TRANSACTIONerror with it. Unfortunately the error object returned is very bare, but at least allows you to inform customers there was a problem with payment. Very surprised this wasn't already implemented.Anyone needing to tie into this event right now, can install from secondary branch where I performed the full build as 3.2.1-rc1: https://github.com/Nicholi/vue-paypal-checkout/tree/beta_3.2.1
npm install --save 'Nicholi/vue-paypal-checkout#beta_3.2.1'