Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close multiprocessing safely #27

Open
yangia opened this issue Nov 18, 2019 · 3 comments
Open

close multiprocessing safely #27

yangia opened this issue Nov 18, 2019 · 3 comments

Comments

@yangia
Copy link

yangia commented Nov 18, 2019

I think

workers.close()
workers.join()

should be added right before the return xxx in method combine_to_panoptic_multi_core and pq_compute_multi_core for closing multiprocessing safely, as my collegue found it might not release the memory properly. I agreed and adopted it, but I didn't test it.

@penguinflys
Copy link

I found the problem too, this has actually caused several downtimes at the server of my boss. I have tested it, and it works well now.

@Basseldonk
Copy link

Agreed. Not closing led to memory leaking problems. The solution proposed by @yangia solved the problem for me.

@dahliau
Copy link

dahliau commented May 16, 2021

Agreed. @yangia thanks for that.
I test it, and workers.close() is enough to close the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants