Codestyle and Good Practices #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppwwyyxx, @yucornetto and @alexander-kirillov, I would like to know if this project is still of interest to you, as I noticed that pull requests have increased, but many of them without your opinion. If the project is already in its state of the art, it is recommended that it be archived. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't changed anything related to the core of the code, but I saw that some details were missing. So:
setup.py;Another good practice is to run some style guide application tools, such as
flake8. So, after installing it, I ran and corrected most of the recommendations, leaving only the Pep8 E501 and two Pep8 E741.