Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with incorrect initialization script order in the editor preview #18299

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

knoxHuang
Copy link
Contributor

Re: # #17792

https://forum.cocos.org/t/topic/165212/72

Changelog

  • Ensure that the script initialization order during editor preview is consistent with that of browser preview.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@knoxHuang knoxHuang requested a review from dumganhar February 8, 2025 06:46
@dumganhar
Copy link
Contributor

unit test failed:

FAIL tests/animation/new-gen-anim/pose-graph/pose-nodes/intensity-specification.test.ts
● Test suite failed to run

TypeError: Cannot read properties of undefined (reading 'Script')

Copy link

github-actions bot commented Feb 8, 2025

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@knoxHuang
Copy link
Contributor Author

Fixed, the code of EDITOR_NOT_IN_PREVIEW at runtime is undefined, and it needs to be matched with EDITOR to be correct

@knoxHuang knoxHuang requested a review from minggo February 8, 2025 07:50
@dumganhar
Copy link
Contributor

@cocos-robot run test cases

Copy link

github-actions bot commented Feb 9, 2025

@knoxHuang, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
ios PASS PASS FAIL reflection-probe
mac PASS PASS FAIL reflection-probe

Copy link

github-actions bot commented Feb 9, 2025

@knoxHuang, Please check the result of run test cases:

Task Details

@minggo minggo merged commit b76643a into cocos:v3.8.6 Feb 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants