Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added strong typing everywhere it was possible.
I also:
@covers
annotations but reverted it because the FQCN is requiredAdding strong typing made me spot two bugs that I fixed in the meantime:
sortKeysWithDefaultSortingAndReverseOption
had a bug, you were passing null assuming it would take the default value. This is not how PHP handles that, default values are provided only if you pass nothing at all. Passing an explicitnull
will give you anull
(now aTypeError
as the param isn't nullable). As you were passing the second argument you've got no choice: you're forced to pass the first.