Default titleProperty to displayProperty (#3134)

coda · Dec 16, 2024 · 4a97b36 · 4a97b36
1 parent f880dcd
commit 4a97b36
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 14 deletions.
diff --git a/dist/bundle.js b/dist/bundle.js
diff --git a/dist/helpers/migration.d.ts b/dist/helpers/migration.d.ts
diff --git a/dist/helpers/migration.js b/dist/helpers/migration.js
diff --git a/helpers/migration.ts b/helpers/migration.ts
@@ -109,6 +109,10 @@ class ObjectSchemaHelper<T extends ObjectSchemaDefinition<string, string>> {
   get requireForUpdates() {
     return this._schema.requireForUpdates;
   }
+
+  get titleProperty() {
+    return this._schema.titleProperty ?? this._schema.displayProperty;
+  }
 }
 
 export function paramDefHelper<S extends UnionType, T extends ParamDef<S>>(def: T): ParamDefHelper<S, T> {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@codahq/packs-sdk",
-  "version": "1.8.6",
+  "version": "1.8.7-prerelease.1",
   "license": "MIT",
   "workspaces": [
     "dev/eslint"

diff --git a/schema.ts b/schema.ts
@@ -1383,7 +1383,7 @@ export interface ObjectSchemaDefinition<K extends string, L extends string>
    * TODO(ebo): Unhide this
    * @hidden
    */
-  versionProperty? : PropertyIdentifier<K>;
+  versionProperty?: PropertyIdentifier<K>;
 
   // TODO(dweitzman): Only support options in the typing when the codaType is ValueHintType.SelectList.
 }

diff --git a/test/upload_validation_test.ts b/test/upload_validation_test.ts
@@ -1935,7 +1935,7 @@ describe('Pack metadata Validation', async () => {
               return {result: []};
             },
             parameters: [],
-            allowedAuthenticationNames: [ReservedAuthenticationNames.System]
+            allowedAuthenticationNames: [ReservedAuthenticationNames.System],
           },
         });
         const syncTable4 = makeSyncTable({
@@ -1956,11 +1956,10 @@ describe('Pack metadata Validation', async () => {
               return {result: []};
             },
             parameters: [],
-            allowedAuthenticationNames: [ReservedAuthenticationNames.Default]
+            allowedAuthenticationNames: [ReservedAuthenticationNames.Default],
           },
         });
 
-
         let metadata = createFakePack({
           syncTables: [syncTable1, syncTable2, syncTable3, syncTable4],
         });
@@ -1994,10 +1993,10 @@ describe('Pack metadata Validation', async () => {
               return {result: []};
             },
             parameters: [],
-            allowedAuthenticationNames: [ReservedAuthenticationNames.Default, ReservedAuthenticationNames.System]
+            allowedAuthenticationNames: [ReservedAuthenticationNames.Default, ReservedAuthenticationNames.System],
           },
         });
-         metadata = createFakePack({
+        metadata = createFakePack({
           syncTables: [syncTable1, syncTable2, syncTable3, syncTable4, syncTable5],
         });
         err = await validateJsonAndAssertFails(metadata);
@@ -2007,12 +2006,14 @@ describe('Pack metadata Validation', async () => {
             path: 'syncTables',
           },
           {
-            message: 'Identity "IdentityAdminAuth" is used by multiple sync tables with non-distinct allowedAuthenticationNames: defaultUserAuthentication',
-            path: 'syncTables'
+            message:
+              'Identity "IdentityAdminAuth" is used by multiple sync tables with non-distinct allowedAuthenticationNames: defaultUserAuthentication',
+            path: 'syncTables',
           },
           {
-            message: 'Identity "IdentityAdminAuth" is used by multiple sync tables with non-distinct allowedAuthenticationNames: systemAuthentication',
-            path: 'syncTables'
+            message:
+              'Identity "IdentityAdminAuth" is used by multiple sync tables with non-distinct allowedAuthenticationNames: systemAuthentication',
+            path: 'syncTables',
           },
           {
             message: 'Sync table formula names must be unique. Found duplicate name "SyncTable".',
@@ -2061,7 +2062,7 @@ describe('Pack metadata Validation', async () => {
             },
             parameters: [],
             // This will still be considered a duplicate because table 1 implicitly allows all auths.
-            allowedAuthenticationNames: [ReservedAuthenticationNames.Default]
+            allowedAuthenticationNames: [ReservedAuthenticationNames.Default],
           },
         });
 
@@ -2071,7 +2072,8 @@ describe('Pack metadata Validation', async () => {
         const err = await validateJsonAndAssertFails(metadata);
         assert.deepEqual(err.validationErrors, [
           {
-            message: 'Identity "Identity" is used by multiple sync tables with non-distinct allowedAuthenticationNames: defaultUserAuthentication',
+            message:
+              'Identity "Identity" is used by multiple sync tables with non-distinct allowedAuthenticationNames: defaultUserAuthentication',
             path: 'syncTables',
           },
           {