Skip to content

Commit

Permalink
Add hasIncompleteResults to completion (#3051)
Browse files Browse the repository at this point in the history
  • Loading branch information
sam-codaio authored Aug 30, 2024
1 parent 2cfa187 commit fde1bf3
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 3 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ This changelog keeps track of all changes to the Packs SDK. We follow convention

## [Unreleased]

### Added

- Internal change to completion

## [1.7.13] - 2024-08-29

### Changed
Expand Down Expand Up @@ -748,5 +752,4 @@ await myHelper(context);
[1.7.12]: https://github.com/coda/packs-sdk/compare/v1.7.8...v1.7.12
[1.7.11]: https://github.com/coda/packs-sdk/compare/v1.7.8...v1.7.11
[1.7.10]: https://github.com/coda/packs-sdk/compare/v1.7.8...v1.7.10
[1.7.13]: https://github.com/coda/packs-sdk/compare/v1.7.8...v1.7.13
2 changes: 1 addition & 1 deletion api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ export interface SyncFormulaResult<K extends string, L extends string, SchemaT e

/**
* Return the list of deleted item ids for incremental sync deletion.
*
*
* TODO(ebo): Unhide this
* @hidden
*/
Expand Down
10 changes: 10 additions & 0 deletions api_types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1024,4 +1024,14 @@ export interface SyncCompletionMetadata {
* next sync execution.
*/
incrementalContinuation?: Continuation;

/**
* Returned by an incremental sync if the results are incomplete. Will be ignored during a full sync.
*
* This will trigger a full sync so that complete results can be obtained.
*
* TODO(sam): Unhide this
* @hidden
*/
hasIncompleteResults?: boolean;
}
9 changes: 9 additions & 0 deletions dist/api_types.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions dist/bundle.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codahq/packs-sdk",
"version": "1.7.13",
"version": "1.7.14-prerelease.1",
"license": "MIT",
"workspaces": [
"dev/eslint"
Expand Down

0 comments on commit fde1bf3

Please sign in to comment.