Adding sync state service to get latest row version based on given row ids #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebo-codaio
requested review from
jonathan-codaio,
patrick-codaio and
ekoleda-codaio
ebo-codaio
force-pushed
the
ebo-row-version
branch
3 times, most recently
from
1be1007 to
7f84325
Compare
api_types.ts
Outdated
| * | ||
| * TODO(ebo): unhide this | ||
| */ | ||
| readonly syncState: SyncStateService; |
There was a problem hiding this comment.
Can we maybe call this syncStateService? Isn't sync an object that already represents "sync state"?
There was a problem hiding this comment.
I guess it might be clearer if we include service in the name? wdyt @erickoledadevrel
There was a problem hiding this comment.
I like adding "Service"
| * | ||
| * TODO(ebo): unhide this | ||
| */ | ||
| getLatestRowVersions(rowIds: string[]): Promise<{[rowId: string]: string}>; |
There was a problem hiding this comment.
We call things items and item ids in most places, but we use "rows" and row ids" here, how come the difference?
There was a problem hiding this comment.
We felt like it would be better to standardize on "rows". Here's the accompanying change, it's pretty small: #3129
There was a problem hiding this comment.
We also already used rows:
ebo-codaio
force-pushed
the
ebo-row-version
branch
from
38343a1 to
c45f2da
Compare
ebo-codaio
force-pushed
the
ebo-row-version
branch
from
c45f2da to
07b401b
Compare
patrick-codaio
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: https://coda.io/d/go-brainwriteups_dQYLHXsHZWS/Pack-SDK-Get-item-versions-interface_suFrdPVO?utm_source=slack#_luPjCMl1
Follow up: update
item idstorow idsfor ingestion related variablesPTAL: @patrick-codaio @erickoledadevrel @jonathan-codaio