Skip to content

Add block files to Eslint configuration file #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DMarinhoCodacy wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add block files to Eslint configuration file #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
608fa37
Add block files to Eslint configuration file
DMarinhoCodacy Nov 25, 2025
bd37df3
revert .codacy changes
DMarinhoCodacy Nov 25, 2025
384f2b5
fix eslint tests
DMarinhoCodacy Dec 11, 2025
fd3db1f
fix test
DMarinhoCodacy Dec 11, 2025
f9a1dfb
fix eslint tests
DMarinhoCodacy Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integration-tests/config-discover/expected/tools-configs/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"constructor-super": ["error"],
"for-direction": ["error"],
Expand Down
1 change: 1 addition & 0 deletions integration-tests/init-with-token/expected/tools-configs/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
}
}
Expand Down
1 change: 1 addition & 0 deletions integration-tests/init-without-token/expected/tools-configs/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"constructor-super": ["error"],
"for-direction": ["error"],
Expand Down
1 change: 1 addition & 0 deletions plugins/tools/eslint/test/src/.codacy/tools-configs/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"constructor-super": ["error"],
"for-direction": ["error"],
Expand Down
1 change: 1 addition & 0 deletions tools/eslintConfigCreator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ var rulesWithoutOptions = map[string]bool{
func CreateEslintConfig(toolsConfigDir string, configuration []domain.PatternConfiguration) error {
result := `export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
Copy link

@codacy-production codacy-production bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] You added files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"]. Confirm that: (1) you want to include both .mjs and .cjs (commonjs vs ESM) — including both is fine but unnecessary if your repo uses only one; (2) any other extensions (e.g. .cts/.mts, .jsx in .tsx projects, or framework specific extensions) are not needed. If this list may grow, extract into a constant or a small helper to keep the template string clearer.

Medium risk | Medium confidence

rules: {
`

Expand Down
8 changes: 8 additions & 0 deletions tools/eslintConfigCreator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ func TestCreateEslintConfigEmptyConfig(t *testing.T) {
[]domain.PatternConfiguration{},
`export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
}
}
Expand All @@ -50,6 +51,7 @@ func TestCreateEslintConfigConfig1(t *testing.T) {
},
`export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"semi": ["error"],
}
Expand All @@ -74,6 +76,7 @@ func TestCreateEslintConfigUnnamedParam(t *testing.T) {
},
`export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"semi": ["error", "never"],
}
Expand All @@ -98,6 +101,7 @@ func TestCreateEslintConfigNamedParam(t *testing.T) {
},
`export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"consistent-return": ["error", {"treatUndefinedAsUnspecified": false}],
}
Expand Down Expand Up @@ -126,6 +130,7 @@ func TestCreateEslintConfigUnnamedAndNamedParam(t *testing.T) {
},
`export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"consistent-return": ["error", "foo", {"treatUndefinedAsUnspecified": false}],
}
Expand All @@ -144,6 +149,7 @@ func TestCreateEslintConfigDoNotSupportPlugins(t *testing.T) {
},
`export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
}
}
Expand Down Expand Up @@ -181,6 +187,7 @@ func TestCreateEslintConfigWithDefaultValues(t *testing.T) {
},
`export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"no-fallthrough": ["error", {"allowEmptyCase": false}],
}
Expand Down Expand Up @@ -211,6 +218,7 @@ func TestCreateEslintConfigWithUnnamedDefaultValues(t *testing.T) {
},
`export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"no-inner-declarations": ["error", "functions"],
}
Expand Down
1 change: 1 addition & 0 deletions tools/testdata/repositories/test1/src/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],
rules: {
"prefer-const": "error"
}
Expand Down