Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Update - Dataset/Program removal fixed #1569

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Aug 22, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

  • It was not possible to remove a dataset or program from a task. Now that is fixed in this PR

Issues this PR resolves

A checklist for hand testing

  • create a new task and check that you can update scoring, ingestion, input, reference
  • check that you cannot remove a scoring program from a task
  • check that you can remove ingestion, input and reference from a task

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Aug 22, 2024 that may be closed by this pull request
@Didayolo Didayolo self-assigned this Aug 29, 2024
@Didayolo
Copy link
Member

Nice work

@Didayolo Didayolo merged commit 56bdd5e into develop Aug 29, 2024
1 check passed
@Didayolo Didayolo deleted the tasks_remove_dataset branch August 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removing dataset from task
2 participants