Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR#3 created workflow for new releases #1584

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Sep 15, 2024

@ mention of reviewers

@ObadaS

A brief description of the purpose of the changes contained in this PR.

Created a workflow and json file for release information.

Issues this PR resolves

A checklist for hand testing

  • We need to test if with a new release publish, this workflow is triggered

Checklist

  • Hand tested by me
  • CircleCi tests are passing
  • Ready to merge

@ObadaS
Copy link
Collaborator

ObadaS commented Sep 16, 2024

Looks good on my end, we only need to test it now

  1. I see in the code that you are using >, what do you think about using >> to have a local file in the repo with all the changes ?
  2. The code doesn't specify a branch, does it push the develop or master branch ? I think we want it to push on the master branch, otherwise we would need to do a separate PR to bring the updated file into master after we already merged into master (since we only publish the Release notes once we have successfully merged into master)

The CircleCI test fails with the same error I have on my local machine when trying to deploy the current develop branch. Seems like there is a problem with the Python version used, which could be an easy fix.

@ihsaan-ullah
Copy link
Collaborator Author

Looks good on my end, we only need to test it now

  1. I see in the code that you are using >, what do you think about using >> to have a local file in the repo with all the changes ?

> will rewrite the file while >> will append. I think we want to rewrite the file

  1. The code doesn't specify a branch, does it push the develop or master branch ? I think we want it to push on the master branch, otherwise we would need to do a separate PR to bring the updated file into master after we already merged into master (since we only publish the Release notes once we have successfully merged into master)

I have updated the workflow to push changes to develop branch and automatically create a PR. We should test it on github if this works or not because I have never worked on workflows. I chose develop branch so that everything is consistent and there is no mismatch between develop and master

@ihsaan-ullah ihsaan-ullah changed the title created workflow for new releases Release PR#3 created workflow for new releases Sep 20, 2024
@ihsaan-ullah ihsaan-ullah mentioned this pull request Sep 21, 2024
@Didayolo
Copy link
Member

Didayolo commented Oct 1, 2024

Here, version.json looks like this:

{
    "tag_name": "1.1.0",
    "release_name": "Second release",
    "published_at": "November 09, 2023",
    "body": ""
}

However, on the PR#2 (#1592) that'll be merged to develop, we have:

{
  "tag_name": "v1.11.0",
  "release_name": "Release 1.11.0",
  "published_at": "2024-09-16",
  "body": "",
  "release_url": "https://github.com/codalab/codabench/releases/tag/v1.11.0"
}

That looks problematic

@ihsaan-ullah
Copy link
Collaborator Author

json updated in the latest commit

@Didayolo
Copy link
Member

Didayolo commented Oct 3, 2024

So should we merge this to develop? @ihsaan-ullah @ObadaS

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Oct 3, 2024

So should we merge this to develop? @ihsaan-ullah @ObadaS

@Didayolo I think yes, we need to test this by releasing a new version

@ObadaS do you know when the workflow will be triggered? if this is in develop or master?

@ObadaS
Copy link
Collaborator

ObadaS commented Oct 3, 2024

It might not get triggered because the workflow file does not exist yet, and there is nothing that was published after the merge happens.
But it should trigger automatically, after the merge, when I publish the 1.12 release

@Didayolo Didayolo merged commit de55ef3 into develop Oct 3, 2024
1 check passed
@Didayolo Didayolo deleted the release-workflow branch October 3, 2024 14:10
Didayolo added a commit that referenced this pull request Oct 11, 2024
* autorun collectstatic when django container starts, added caddy_data and caddy_config to gitignore

* programs and datasets bug fixed

* if condition format fixed

* Downloading submissions witha stream v1

* updated toml file with python version and bpython version, deleted lock file, update dockerfile to not copy lock file and to generate lock file in the docker build

* Change base image for Dockerfile.flower (#1520)

* Change base image for Dockerfile.flower

* Remove platform argument

* Resources bundles dumps (#1505)

* Add a Bundles tab in Resources view

* add dump single and multiple deletion mechanism

* add competition title in bundle name + add competition link in bundle resource tab

* Update datasets.py (flake8)

---------

Co-authored-by: OhMaley <tristanmary2@gmail.com>
Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* Improve formatting

* leaderboard api 500 error resolved (#1527)

* leaderboard api 500 error resolved

* flake issues resolved

* Changed submission name to add ID when downloading many submissions (#1565)

* changed submission name to add ID

* Flake8 white space fix

---------

Co-authored-by: Nicolas HOMBERG <nicolashomberg@gricad-nh.u-ga.fr>

* Server Status:  submissions limit removed (#1562)

* server status submissions limit removed, pagination added, monitor queues separated

* renamed server status title to recent submissions

* Email template fixes (#1567)

* email logo fixed, some changes in email text

* participant side email templates updated

* task dataset/program removal fixed

* Updated docker-compose to docker compose

* whiltelist emails leaking fixed (#1560)

* competition whitelist feature added

* updated whitelist

* Update whitelist note

* whiltelist emails leaking fixed

* Remove conflict

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* Updates to server_status and monitor_queues (#1568)

* server_status and monitor_queues pages secured

* Update monitor_queues.html

* [Feature] Delete orphan files (#1575)

* Add button for orphan files deletion + API routes and views

* Fix flake8 formatting

---------

Co-authored-by: OhMaley <tristanmary2@gmail.com>

* Fix string concat in case of no email in analytics api

* Poetry error tentative fix (#1588)

* Poetry error tentative fix

* RabbitMQ static image in Dockerfile.rabbitmq to fix a recent bug

* Reverted RabbitMQ image change

* Fix Rabbit version

---------

Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: didayolo <adrien.pavao@gmail.com>

* `Release PR#1` - Display release version in Codabench footer (#1583)

* release version added to header

* version moved to footer

* Minor UI change

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* `Release PR#2` Release version will load dynamically from version.json (#1592)

* release version added to header

* version moved to footer

* version on the website is now dynamic and will be loaded from the version.json file

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* `Release PR#3` created workflow for new releases (#1584)

* created workflow for new releases

* version json file added

* typo fix

* Update release-version-update.yml

* Included realease url to navigate user to the url on click on the website

* release json updated

---------

Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* Updates Sept 15-22 2024 (#1593)

* jinja and pillow

* jinja and pillow

* Adding Versino_Bump_Instruction_README

* Version_Bumps file

* Version_Bumps file and req_treeFile updates

* gunicorn from 20.0.4 to 22.0.0

* Bump requests from 2.20.0 to 2.32.2

* Bump django from 2.2.17 to 2.2.18

* Bump django from 2.2.18 to 2.2.19 and to 3.2.25 eventually

* Bump django from 2.2.19 to 2.2.20

* Bump django from 2.2.20 to 2.2.25

* Bump django from 2.2.25 to 2.2.28

* Bump django from 2.2.25 to 2.2.28

* Version_Bumps.md text

* Update Dockerfile (upgrade Python)

* checking in some outstanding changes

* Remove Version Bumps

* removing version bumbs

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* organizers can now delete forum posts (#1613)

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* bundles renamed to competition bundles, swapped postions of bundles and tasks (#1591)

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

---------

Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Nicolas HOMBERG <nicolashomberg@gricad-nh.u-ga.fr>
Co-authored-by: OhMaley <tristanmary2@gmail.com>
Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: Obada Haddad-Soussac <osobada.03@hotmail.fr>
Co-authored-by: Benjamin Bearce <bbearce@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants