Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string concat in case of no email in analytics api #1585

Conversation

OhMaley
Copy link
Collaborator

@OhMaley OhMaley commented Sep 16, 2024

A brief description of the purpose of the changes contained in this PR.

Fixes the bug where the analytics API calls for displaying Competitions and Users usage crashes due to nonexistent email linked to any user.

The solution adds a default string value in such case, None and str concatenation (which does not exist)

Issues this PR resolves

#1577

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Ready to merge

@OhMaley OhMaley added the Bug label Sep 16, 2024
@OhMaley OhMaley requested a review from ObadaS September 16, 2024 15:15
@Didayolo Didayolo linked an issue Sep 16, 2024 that may be closed by this pull request
@Didayolo Didayolo changed the base branch from develop to fix/storage/analytics-api-handle-none-edge-case October 11, 2024 11:19
@Didayolo Didayolo merged commit 5fc4c2e into codalab:fix/storage/analytics-api-handle-none-edge-case Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Analytics: Competitions and Users usage not loading
2 participants