-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: rust fetch return types not qualified properly #401
Conversation
🦋 Changeset detectedLatest commit: ae52cc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A comment not directly related to this PR: would it make sense for the fetch_all_*
variants to take a Vec<&Pubkey>
since the fetch_
ones take a &Pubkey
?
@febo I believe solana_client crate does (Changing would probably be fine given this has never worked in a live version even though it would strictly be a breaking change) |
Agreed, let's match the API of |
Fixed! |
Thank you! Just waiting on Febo's approval and LGTM. Would you mind just rebasing the PR? Sorry I just merged another big PR and it created small conflicts. |
2d144d9
to
479a3c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
introduced by #299. Tests did not catch this because the functions/types are behind a feature