Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Window Loop #1245

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Hot Window Loop #1245

wants to merge 6 commits into from

Conversation

mstijak
Copy link
Member

@mstijak mstijak commented Dec 6, 2024

No description provided.

@mstijak
Copy link
Member Author

mstijak commented Dec 12, 2024

Naming thoughts...

createHotPromiseWindowFactoryWithProps => createHotPromisePropsWindowFactory?
createHotPromiseWindowWithPropsFactory

PromiseWindow or WindowPromise?
createHotWindowPromiseFactory
createHotPropsWindowPromiseFactory
createHotWindowWithPropsPromiseFactory
createHotWindowWithPropsPromiseFactory

@nebojsa-peric
Copy link
Collaborator

For the factory without props I like createHotPromiseWindowFactory (PromiseWindow seems more suitable, like a special kind of a Window in terms of Cx).
Regarding props, if they relate to Window, I would rather finish the name with the Factory as the last word: createHotPromiseWindowWithPropsFactory

In any case, all versions sound ok for me and the functionality beats the naming decision.

ChatGPT is also suggesting createHotAsyncWindowFactory, which sounds good to me, and the other one createLiveAsyncWindowFactory. In case of async, at least it's obvious whether it goes before or after the Window :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants