updating location of logic for getmail command #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a method under Mailbox so it can be called from other modules
| @@ -4,27 +4,10 @@ | |||
|
|
|||
| from django_mailbox.models import Mailbox | |||
|
|
|||
|
|
|||
| logger = logging.getLogger(__name__) | |||
There was a problem hiding this comment.
I know this is where I put this, but could I convince you into moving these two logger lines into the handle method below so importing this module is side-effect free?
There was a problem hiding this comment.
done with f531c78
|
@coddingtonbear thanks for merging 😄 Do I need to submit another PR to bump the versions or will you do that yourself? |
|
No, no, I can sort that out! Thanks for taking the time to put together a patch, @modernNeo! |
|
Hi @coddingtonbear , when do you think you will get around to releasing the patch? |
emilyh2
added a commit
to factal-inc/django-mailbox
that referenced
this pull request
Feb 14, 2024
* Fix message/rfc822 attachment processing * Update models.py, __init__.py, and office365.py * Update setup.py * Office365Transport properties * Update .gitignore * wrong folder stage * Update models.py * Update office365.py and models.py * office365 implementation * Update office365.py * clear code * fix import * Update readme.rst * archive and delete * fix and documentation * removed build folder * missing archive * Office365 API mailbox support (coddingtonbear#251) * Update models.py, __init__.py, and office365.py * Update setup.py * Office365Transport properties * Update .gitignore * wrong folder stage * Update models.py * Update office365.py and models.py * office365 implementation * Update office365.py * clear code * fix import * Update readme.rst * archive and delete * fix and documentation * removed build folder * missing archive Co-authored-by: Pietro Mingo <p.mingo@intac.it> Co-authored-by: Serafim Bordei <s.bordei@intac.it> * updating location of logic for getmail command (coddingtonbear#264) * moving logic for processing all the new emails from all mailboxes to a method under Mailbox so it can be called from other modules * moving logger lines into handle method as requested * Update utils.py Fixing DJANGO_MAILBOX_default_charset error, it does not detect the settings in django correctly because one part is in lower case. Changed to DJANGO_MAILBOX_DEFAULT_CHARSET. * Initial Bulgarian translation * Close attachments * Support for Django 5.0 and python 3.12 + Fix CI (coddingtonbear#277) * Upgrade to last Django & Python supported versions * flake8 fixes * Add CI * Add final version of Django 5.0 * Bump version: 4.8.2 → 4.9.0 * fix CI implemented by pfouque * Change to documentation regarding Office365 configuration * Remove south migrations * cleanup and update * Fix DJANGO_MAILBOX_DEFAULT_CHARSET setting * Make eml field Blankable * MailboxAttachment __str__ change * Update django_mailbox/models.py Co-authored-by: Pascal Fouque <pfouque@users.noreply.github.com> * Remove default_app_config --------- Co-authored-by: Miłosz Jerkiewicz <milosz.jerkiewicz@baumeister-rosing.de> Co-authored-by: Pietro Mingo <p.mingo@intac.it> Co-authored-by: Pietro Mingo <pietro.mingo@gmail.com> Co-authored-by: Serafim Bordei <s.bordei@intac.it> Co-authored-by: Pietro Mingo <50447537+skar395@users.noreply.github.com> Co-authored-by: Jace Manshadi <jmanshad@protonmail.com> Co-authored-by: Robersillo <31243904+Robersillo@users.noreply.github.com> Co-authored-by: Arneatec <nouser@nodomain.com> Co-authored-by: Martin Manzo <martinmanzo@users.noreply.github.com> Co-authored-by: Pietro <me@pietro.in> Co-authored-by: Pascal F <pfouque@users.noreply.github.com> Co-authored-by: Adam Coddington <me@adamcoddington.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving logic for processing all the new emails from all mailboxes to a method under Mailbox so it can be called from other modules