Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatability with deflationary / fee-on-transfer tokens #16

Open
code423n4 opened this issue May 19, 2021 · 1 comment
Open

Incompatability with deflationary / fee-on-transfer tokens #16

code423n4 opened this issue May 19, 2021 · 1 comment
Labels
2 (Med Risk) bug Something isn't working sponsor acknowledged

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

Vulnerability Details

The DInterest.deposit function takes a depositAmount parameter but this parameter is not the actual transferred amount for fee-on-transfer / deflationary (or other rebasing) tokens.

Impact

The actual deposited amount might be lower than the specified depositAmount of the function parameter.
This would lead to wrong interest rate calculations on the principal.

Recommended Mitigation Steps

Transfer the tokens first and compare pre-/after token balances to compute the actual deposited amount.
@code423n4 code423n4 added 2 (Med Risk) bug Something isn't working labels May 19, 2021
code423n4 added a commit that referenced this issue May 19, 2021
@code423n4
cmichel issue #16
2c7e7db
@ZeframLou
Copy link
Collaborator

While this is true, we have no plans to support fee-on-transfer or rebasing tokens.

@Splidge Splidge mentioned this issue Jun 17, 2021
Open
@code423n4 code423n4 mentioned this issue Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) bug Something isn't working sponsor acknowledged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZeframLou @code423n4