Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing emit for WithdrawnBatch event #114

Closed
code423n4 opened this issue Jun 16, 2021 · 2 comments
Closed

Missing emit for WithdrawnBatch event #114

code423n4 opened this issue Jun 16, 2021 · 2 comments
Labels
0 (Non-critical) bug Something isn't working disagree with severity duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

0xRajeev

Vulnerability details

Impact

Missing emit for this WithdrawnBatch event indicates a missing batch withdrawal functionality that appears to be unimplemented in RCNftHubL2.

Proof of Concept

https://github.com/code-423n4/2021-06-realitycards/blob/86a816abb058cc0ed9b6f5c4a8ad146f22b8034c/contracts/nfthubs/RCNftHubL2.sol#L37

Tools Used

Manual Analysis

Recommended Mitigation Steps

Evaluate if this functionality is indeed missing and implement it to emit the declared event. If not, remove event declaration.
@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Jun 16, 2021
code423n4 added a commit that referenced this issue Jun 16, 2021
@code423n4
0xRajeev issue #114
79b2592
@Splidge Splidge added disagree with severity duplicate This issue or pull request already exists labels Jun 18, 2021
@Splidge
Copy link
Collaborator

Splidge commented Jun 18, 2021

Duplicate of #32

@Splidge Splidge marked this as a duplicate of #32 Jun 18, 2021
@Splidge Splidge closed this as completed Jun 18, 2021
@dmvt dmvt removed the 1 (Low Risk) label Jul 10, 2021
@dmvt
Copy link
Collaborator

dmvt commented Jul 10, 2021

duplicate of #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working disagree with severity duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmvt @Splidge @code423n4