Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redudant calculations in payRent when marketBalance < _amount #123

Open
code423n4 opened this issue Jun 16, 2021 · 1 comment
Open

Redudant calculations in payRent when marketBalance < _amount #123

code423n4 opened this issue Jun 16, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) resolved sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

_amount -= (_amount - marketBalance);
is basically the same as:
_amount = marketBalance;
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jun 16, 2021
code423n4 added a commit that referenced this issue Jun 16, 2021
@code423n4
pauliax issue #123
80d110e
@Splidge
Copy link
Collaborator

Splidge commented Jun 21, 2021

fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) resolved sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Splidge @code423n4