Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbounded iteration on _cardAffiliateAddresses #154

Open
code423n4 opened this issue Jun 16, 2021 · 1 comment
Open

Unbounded iteration on _cardAffiliateAddresses #154

code423n4 opened this issue Jun 16, 2021 · 1 comment
Labels
1 (Low Risk) bug Something isn't working resolved sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

Vulnerability Details

The Factory.createMarket iterates over all _cardAffiliateAddresses.

Impact

The transactions can fail if the arrays get too big and the transaction would consume more gas than the block limit.
This will then result in a denial of service for the desired functionality and break core functionality.

Recommended Mitigation Steps

Perform a _cardAffiliateAddresses.length == 0 || _cardAffiliateAddresses.length == tokenUris.length check in createMarket instead of silently skipping card affiliate cuts in Market.initialize.
This would restrict the _cardAffiliateAddresses length to the nftMintingLimit as well.
@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Jun 16, 2021
code423n4 added a commit that referenced this issue Jun 16, 2021
@code423n4
cmichel issue #154
1785c29
@Splidge
Copy link
Collaborator

Splidge commented Jun 21, 2021

implemented here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) bug Something isn't working resolved sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Splidge @code423n4