Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Mode instead of uint in RCFactory to make code much more readable #162

Open
code423n4 opened this issue Jun 16, 2021 · 2 comments
Open

Use Mode instead of uint in RCFactory to make code much more readable #162

code423n4 opened this issue Jun 16, 2021 · 2 comments
Labels
0 (Non-critical) bug Something isn't working resolved sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

a_delamo

Vulnerability details

On RCFactory is using uint to represent the enum Mode while on RCMarket is using the enum directly.
It would make the code much readable if RCFactory would use Mode directly.
@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Jun 16, 2021
code423n4 added a commit that referenced this issue Jun 16, 2021
@code423n4
a_delamo issue #162
80ab3ca
@Splidge
Copy link
Collaborator

Splidge commented Jun 18, 2021

Related to, but not quite a duplicate of #9 I think.

@Splidge
Copy link
Collaborator

Splidge commented Jun 21, 2021

I'm not so sure this affected readability at all given that the Factory doesn't care what the actual mode is.
Regardless, implemented here

@Splidge Splidge mentioned this issue Jun 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working resolved sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Splidge @code423n4