Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of assert() instead of require() for input validation in RCmarket.sol #57

Closed
code423n4 opened this issue Jun 15, 2021 · 3 comments
Closed
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

JMukesh

Vulnerability details

Impact

assert() is used for internal error checking and require() is used to check on input condition, but here assert() is used for input checking

Proof of Concept

https://docs.soliditylang.org/en/v0.8.5/control-structures.html#panic-via-assert-and-error-via-require

https://github.com/code-423n4/2021-06-realitycards/blob/main/contracts/RCMarket.sol#L202

Tools Used

manual review

Recommended Mitigation Steps

use require

@Splidge
Copy link
Collaborator

Splidge commented Jun 16, 2021

This could be considered a duplicate of #44

@Splidge Splidge added sponsor confirmed duplicate This issue or pull request already exists labels Jun 16, 2021
@Splidge
Copy link
Collaborator

Splidge commented Jun 17, 2021

Duplicate of #155

@Splidge Splidge marked this as a duplicate of #155 Jun 17, 2021
@Splidge Splidge closed this as completed Jun 17, 2021
@dmvt
Copy link
Collaborator

dmvt commented Jul 11, 2021

duplicate of #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed
Projects
None yet
Development

No branches or pull requests

3 participants