Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent bids in WINNER_TAKES_ALL when it is no longer possible to win #64

Open
code423n4 opened this issue Jun 16, 2021 · 1 comment
Open

prevent bids in WINNER_TAKES_ALL when it is no longer possible to win #64

code423n4 opened this issue Jun 16, 2021 · 1 comment
Labels
0 (Non-critical) bug Something isn't working sponsor acknowledged

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

This is just a suggestion and food for thought. In WINNER_TAKES_ALL mode new bids may not be allowed when the conditions become such that it won't be possible to win anyway, e.g. time left is not enough to become a longestOwner. I am not sure if such decisions should be left to the users or enforced algorithmically, just wanted to inform you about such a possibility.
@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Jun 16, 2021
code423n4 added a commit that referenced this issue Jun 16, 2021
@code423n4
pauliax issue #64
c04411e
@mcplums
Copy link
Collaborator

mcplums commented Jun 17, 2021 •
edited
Loading

Defo happy to confirm this as a level 0 issue, but I don't think anything is actually required here, we can enforce this via the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working sponsor acknowledged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcplums @Splidge @code423n4