Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_realitioAddress not used #7

Open
code423n4 opened this issue Jun 13, 2021 · 1 comment
Open

_realitioAddress not used #7

code423n4 opened this issue Jun 13, 2021 · 1 comment

Comments

@code423n4
Copy link
Contributor

Handle

gpersoon

Vulnerability details

Impact

The variable _realitioAddress of RCMarket.sol isn't used. The variable realitio seems to used instead.
Two variables with the same purpose is confusing.

Proof of Concept

https://github.com/code-423n4/2021-06-realitycards/blob/main/contracts/RCMarket.sol#L121
IRealitio public realitio;
address public _realitioAddress;

Tools Used

Recommended Mitigation Steps

Remove address public _realitioAddress;

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jun 13, 2021
code423n4 added a commit that referenced this issue Jun 13, 2021
This was referenced Jun 14, 2021
@Splidge
Copy link
Collaborator

Splidge commented Jun 17, 2021

Fix implemented here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants