NFT minting limit dependence on block gas limit

[code423n4]

Handle

0xRajeev

Vulnerability details

Impact

The current block gas limit is 15M and not 12.5 as indicated in the comment for setNFTMintingLimit(60) in Factory’s constructor. So this could be changed accordingly but a safe threshold needs to be enforced in the setter setNFTMintingLimit() which is currently lacking. That would prevent accidentally setting the minting limit to something beyond what the block gas limit would safely allow.

Proof of Concept

https://github.com/code-423n4/2021-06-realitycards/blob/86a816abb058cc0ed9b6f5c4a8ad146f22b8034c/contracts/RCFactory.sol#L132

https://github.com/code-423n4/2021-06-realitycards/blob/86a816abb058cc0ed9b6f5c4a8ad146f22b8034c/contracts/RCFactory.sol#L267-L272

Tools Used

Manual Analysis

Recommended Mitigation Steps

If NFT minting limit dependence on block gas limit is critical to the functioning, consider using GASLIMIT opcode to dynamically check block gas limit to set nftMintingLimit appropriately before creating a market.

[Splidge]

The minting limit isn't critical to the functioning, 60 is already far beyond what we anticipate is required.
The contracts will actually be deployed on Matic/Polygon which has an even higher gas limit still (although adjustable).