Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment of variables not needed #36

Open
code423n4 opened this issue Jul 11, 2021 · 1 comment
Open

Assignment of variables not needed #36

code423n4 opened this issue Jul 11, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.

Comments

@code423n4
Copy link
Contributor

Handle

s1m0

Vulnerability details

Impact

The following variables are being assigned their default value so it's not needed.

Proof of Concept

Tools Used

Manual Analysis

Recommended Mitigation Steps

Remove the assignments for saving a bit of gas when deploying.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jul 11, 2021
code423n4 added a commit that referenced this issue Jul 11, 2021
@code423n4
s1m0 issue #36
2c5750c
@LayneHaber LayneHaber added the sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons. label Jul 13, 2021
@LayneHaber
Copy link
Collaborator

We are taking out the loop in favor of the EnumerableSet from OpenZeppelin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LayneHaber @code423n4