Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached _ethBalance #25

Open
code423n4 opened this issue Sep 8, 2021 · 0 comments
Open

Use cached _ethBalance #25

code423n4 opened this issue Sep 8, 2021 · 0 comments

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

function _addMaxLiquidityEth in contract UniswapSwapper extracts eth balance to a variable _ethBalance but later does not use it and queries address(this).balance again. Use this cached value to save on gas.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Sep 8, 2021
code423n4 added a commit that referenced this issue Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants